Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use tree enumerators #339

Closed
wants to merge 11 commits into from
Closed

feat: use tree enumerators #339

wants to merge 11 commits into from

Conversation

bashbunni
Copy link
Member

@bashbunni bashbunni commented Jul 18, 2024

  • feat: add Root option for lists
  • refactor: use tree enumerators

When a list is used as the root of a list, it merges the items and inherits the name of the root list. Otherwise it looks like the sub-list belongs to the last element in the root list.

e.g.
image

This but imagine the "More Documents", etc are indented

Instead it looks like
image

Where the root tree's items are appended to the end of the list

@bashbunni bashbunni changed the base branch from master to list-title July 18, 2024 20:56
@bashbunni
Copy link
Member Author

Builds off of the other PR that adds the Title func to set a name for the list

@bashbunni bashbunni changed the base branch from list-title to beta July 19, 2024 18:15
@meowgorithm
Copy link
Member

meowgorithm commented Jul 19, 2024

Looking good. Want to merge this with #338 so we can treat this as a general pass over tree/list? I think it'll be easier to reason about that way.

@bashbunni
Copy link
Member Author

I think we should have the Indenter default to TreeIndenter when we set the Enumerator to list.Tree or list.RoundedTree. It feels weird having to specify that every time

@maaslalani
Copy link
Contributor

Agreed!

@bashbunni bashbunni marked this pull request as draft July 23, 2024 15:53
@bashbunni
Copy link
Member Author

🌴

@caarlos0 caarlos0 changed the base branch from beta to master July 23, 2024 21:13
@caarlos0 caarlos0 changed the base branch from master to beta July 23, 2024 21:13
@caarlos0 caarlos0 mentioned this pull request Jul 23, 2024
@bashbunni
Copy link
Member Author

Closing in favour of bringing trees out of internal #342

@bashbunni bashbunni closed this Aug 1, 2024
@bashbunni bashbunni deleted the use-tree-enumerators branch August 2, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants