Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): properly shut down if failed to start #138

Merged
merged 1 commit into from
May 27, 2023
Merged

Conversation

caarlos0
Copy link
Member

Without this change, if the server fails to start, the program will hang waiting for a signal on done before properly exiting.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added bug Something isn't working documentation Improvements or additions to documentation labels May 15, 2023
@caarlos0 caarlos0 self-assigned this May 15, 2023
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #138 (bca88af) into main (a7e4853) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   76.14%   76.14%           
=======================================
  Files          17       17           
  Lines         897      897           
=======================================
  Hits          683      683           
  Misses        160      160           
  Partials       54       54           

@caarlos0 caarlos0 merged commit 5551c89 into main May 27, 2023
@caarlos0 caarlos0 deleted the example-fix branch May 27, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant