fix: create a new pty for exec.Cmd #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pty-command #230 +/- ##
==============================================
Coverage ? 77.23%
==============================================
Files ? 19
Lines ? 940
Branches ? 0
==============================================
Hits ? 726
Misses ? 160
Partials ? 54 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
|
It "kinda" works on windows, but when the pty dies, so dies the parent process (the wish server). Not sure if it is fixable... |
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
caarlos0
added a commit
that referenced
this pull request
Jan 30, 2024
* feat: add wish.Command and wish.Cmd The wish-exec example with vim worked because neovim was not using STDERR. Bubbletea doesn't have a concept of stdout and stderr, just output, so `tea.ExecProcess` sets the `exec.Cmd` stderr to `os.Stderr`. This would fail for bash, for instance. This also introduces a `wish.Cmd` type and a `wish.Command` function to properly set up a `wish.Cmd` based on `ssh.Session` (and optionally a Pty), which can then be used with `tea.Exec`. Finally, it adds to the wish-exec example, including the `s` key to run a shell (bash). closes #228 Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * feat: allow to set dir and env * refactory: move things around a bit Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: loop * test: add some tests Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: more tests Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: more tests Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: improve tests Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: windows Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: review Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: improve cmd * fix: create a new pty for exec.Cmd (#230) * fix: create a new pty for exec.Cmd Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: improvements * fix: test * fix: windows Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: unneeded err Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: resize && race Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: windows/linux Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: ignore on windows for now Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: sync Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * test: hammer Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * chore: import --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> * fix: update ssh Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com> --------- Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dirty fix to "inappropriate ioctl for device" on macOS.
It seems that macOS kills the slave pty once
exec.Cmdfinishes... so we need to create a new PTY just to run said program in order to avoid that problem.Need to test, but this might make things possible on windows, too.