Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improving examples and docs #235

Merged
merged 6 commits into from
Feb 6, 2024
Merged

docs: improving examples and docs #235

merged 6 commits into from
Feb 6, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Feb 5, 2024

No description provided.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 marked this pull request as ready for review February 5, 2024 19:17
@caarlos0 caarlos0 added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 5, 2024
@caarlos0 caarlos0 self-assigned this Feb 5, 2024
Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Few gotchas, looks good otherwise :)

examples/pty/main.go Show resolved Hide resolved
examples/pty/main.go Show resolved Hide resolved
Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
@caarlos0 caarlos0 merged commit 23261db into main Feb 6, 2024
12 checks passed
@caarlos0 caarlos0 deleted the docs branch February 6, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants