[kube-state-metrics] add security context #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niedbalski
force-pushed
the
fix-1906303
branch
from
753914b
to
a396b9a
Compare
Cynerva
reviewed
Dec 1, 2020
Fixes LP: #1906303, by patching the deployment manifest of kube-state-metrics according to upstream patch kubernetes/kube-state-metrics#1034 Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
niedbalski
force-pushed
the
fix-1906303
branch
from
a396b9a
to
6588615
Compare
|
@Cynerva fixed the issue pointed out. is there anything at my end to be done? |
|
Nope, this LGTM. Thank you! Heads up, it might be a bit before we can merge this. We're currently in code freeze for Charmed Kubernetes 1.20, and it looks like we're still building cdk-addons 1.20 from master, so I can't land it just yet. The launchpad issue has the review-needed tag though so we shouldn't lose track of this. As far as when this is likely to get released (including backports to 1.18 and 1.19), it would probably go out with Charmed Kubernetes 1.20+ck1 which I would guess will be sometime in January or February. If you need it sooner than that, let us know. |
Cynerva
pushed a commit
that referenced
this pull request
Feb 19, 2021
Fixes LP: #1906303, by patching the deployment manifest of kube-state-metrics according to upstream patch kubernetes/kube-state-metrics#1034 Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
Cynerva
pushed a commit
that referenced
this pull request
Feb 19, 2021
Fixes LP: #1906303, by patching the deployment manifest of kube-state-metrics according to upstream patch kubernetes/kube-state-metrics#1034 Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
Cynerva
pushed a commit
that referenced
this pull request
Feb 19, 2021
Fixes LP: #1906303, by patching the deployment manifest of kube-state-metrics according to upstream patch kubernetes/kube-state-metrics#1034 Signed-off-by: Jorge Niedbalski <jorge.niedbalski@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LP: #1906303, by patching the deployment manifest of kube-state-metrics according to upstream patch
kubernetes/kube-state-metrics#1034
Signed-off-by: Jorge Niedbalski jorge.niedbalski@canonical.com