Improvements in keeping or destroying models #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
commented
Feb 27, 2024
Comment on lines
-569
to
+598
| if self._init_keep_model: | ||
| return True | ||
| current_state = self.current_alias and self._models.get(self.current_alias) | ||
| return current_state.keep if current_state else False | ||
| return current_state.keep if current_state else self._init_keep_model |
There was a problem hiding this comment.
So long as the model exists, track_model will ensure the value of keep is set according to the spec.
If the current_alias is unset or the model isn't found -- fall back to the global flag.
addyess
commented
Feb 27, 2024
| @@ -730,7 +756,7 @@ async def track_model( | |||
| model_name: Optional[str] = None, | |||
| cloud_name: Optional[str] = None, | |||
| use_existing: Optional[bool] = None, | |||
| keep: Optional[bool] = None, | |||
| keep: Union[ModelKeep, str, bool, None] = ModelKeep.IF_EXISTS, | |||
addyess
commented
Feb 27, 2024
Comment on lines
+799
to
+800
| if isinstance(keep, str): | ||
| keep = OpsTest.ModelKeep(keep.lower()) |
There was a problem hiding this comment.
map strings into enum values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce Enumerations to preserve or destroy various tracked models