Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move integration tests to juju 2.9, 3.1, and 3.3 #128

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Move integration tests to juju 2.9, 3.1, and 3.3 #128

merged 4 commits into from
Feb 27, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Feb 27, 2024 •
edited

  • Test with juju 2.9, 3.1, and 3.3
  • Also use charm-channel 3.x/stable to properly build reactive charms
  • Pin sniffio<1.3.0 because after 2 years this dep finally decided it hated old setuptools
  • archive built charms in the event that the tests fail

@addyess addyess force-pushed the akd/integration-tests-patch-up branch 2 times, most recently from bf0b92c to 514661b Compare February 27, 2024 21:52
@addyess addyess force-pushed the akd/integration-tests-patch-up branch from 514661b to 280c55d Compare February 27, 2024 22:06
kwmonroe
kwmonroe approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that charm-channel had me slippin, but i'm on board now.

LGTM.

kwmonroe
kwmonroe reviewed Feb 27, 2024
View reviewed changes
.github/workflows/tests.yaml
@@ -48,6 +48,7 @@ jobs:
run: |
mkdir -p tmp/
mv $HOME/.local/state/charmcraft/log/* tmp/ | true
shopt -s globstar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@kwmonroe kwmonroe merged commit 40be682 into main Feb 27, 2024
9 checks passed
@kwmonroe kwmonroe deleted the akd/integration-tests-patch-up branch February 27, 2024 23:23
@addyess addyess mentioned this pull request Feb 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwmonroe kwmonroe kwmonroe approved these changes

@mateoflorido mateoflorido Awaiting requested review from mateoflorido

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@addyess @kwmonroe