Improve error message with id of the canvas (#10495)

* improve error message with id of the canvas * update test
chartjs · Jul 20, 2022 · 1a1e683 · 1a1e683
1 parent 97351d1
commit 1a1e683
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/core/core.controller.js b/src/core/core.controller.js
@@ -111,7 +111,7 @@ class Chart {
     if (existingChart) {
       throw new Error(
         'Canvas is already in use. Chart with ID \'' + existingChart.id + '\'' +
-				' must be destroyed before the canvas can be reused.'
+				' must be destroyed before the canvas with ID \'' + existingChart.canvas.id + '\' can be reused.'
       );
     }
 

diff --git a/test/specs/core.controller.tests.js b/test/specs/core.controller.tests.js
@@ -32,7 +32,7 @@ describe('Chart', function() {
     expect(createChart).toThrow(new Error(
       'Canvas is already in use. ' +
 			'Chart with ID \'' + chart.id + '\'' +
-			' must be destroyed before the canvas can be reused.'
+			' must be destroyed before the canvas with ID \'' + chart.canvas.id + '\' can be reused.'
     ));
 
     chart.destroy();