Fix adding and removing datasets in bar samples (#5663)

Account for zero indexing of arrays when creating a name for an added dataset and remove the last dataset in the array when removing a dataset rather than removing the first.
chartjs · Aug 8, 2018 · ab41173 · ab41173
1 parent a9c4e37
commit ab41173
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/samples/charts/bar/horizontal.html b/samples/charts/bar/horizontal.html
@@ -102,7 +102,7 @@
 			var colorName = colorNames[horizontalBarChartData.datasets.length % colorNames.length];
 			var dsColor = window.chartColors[colorName];
 			var newDataset = {
-				label: 'Dataset ' + horizontalBarChartData.datasets.length,
+				label: 'Dataset ' + (horizontalBarChartData.datasets.length + 1),
 				backgroundColor: color(dsColor).alpha(0.5).rgbString(),
 				borderColor: dsColor,
 				data: []
@@ -130,7 +130,7 @@
 		});
 
 		document.getElementById('removeDataset').addEventListener('click', function() {
-			horizontalBarChartData.datasets.splice(0, 1);
+			horizontalBarChartData.datasets.pop();
 			window.myHorizontalBar.update();
 		});
 

diff --git a/samples/charts/bar/vertical.html b/samples/charts/bar/vertical.html
@@ -95,7 +95,7 @@
 			var colorName = colorNames[barChartData.datasets.length % colorNames.length];
 			var dsColor = window.chartColors[colorName];
 			var newDataset = {
-				label: 'Dataset ' + barChartData.datasets.length,
+				label: 'Dataset ' + (barChartData.datasets.length + 1),
 				backgroundColor: color(dsColor).alpha(0.5).rgbString(),
 				borderColor: dsColor,
 				borderWidth: 1,
@@ -125,7 +125,7 @@
 		});
 
 		document.getElementById('removeDataset').addEventListener('click', function() {
-			barChartData.datasets.splice(0, 1);
+			barChartData.datasets.pop();
 			window.myBar.update();
 		});