Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Resize simple fix not in documentation #11489

Open
1 of 3 tasks
DavidAshburn opened this issue Sep 6, 2023 · 3 comments
Open
1 of 3 tasks

Responsive Resize simple fix not in documentation #11489

DavidAshburn opened this issue Sep 6, 2023 · 3 comments

Comments

@DavidAshburn
Copy link

Documentation Is:

  • Missing or needed?
  • Confusing
  • Not sure?

Please Explain in Detail...

#4156
this issue could be cleared with a documentation update.

Responsive charts belong in their own relative position div to control their sizing which is fine.
When that div is inside a grid or flexbox, there are some overflow issues when resizing the window to smaller sizes due to intrinsic sizing in grid and flex containers.

The fix is really simple, the relative div needs a 'min-width: 0' in order for these containers to shrink the content correctly. Otherwise it overflows its parent container.

Everything works great after that addition but it takes a bit of googling to find the fix for this issue. Adding to the docs would be easy and convenient.

Your Proposal for Changes

Responsive Charts
-If your chart is inside a grid or flexbox, give the containing div used for sizing a min-width: 0. This allows the chart to shrink and grow with the intrinsic flexbox or grid sizing.

Example

No response

@etimberg
Copy link
Member

etimberg commented Sep 6, 2023

Happy to review a pr updating the docs to be more extensive here

@Thanush19
Copy link

Can I fix this??

@DavidAshburn
Copy link
Author

DavidAshburn commented Sep 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants