-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing: support dot(s) in object keys #10517
Conversation
@kurkle No problem! It's great that you found a faster solution! |
@kurkle, what do you think about adding performance tests? I think it would help new contributors. If you don't mind, I can try to realize it. |
That would be great! |
@kurkle awesome! Can you share with me your large database and how you checked performance? I think this will be a good starting point. |
I've been usin uPlot bench dataset, available at https://github.com/leeoniya/uPlot/blob/master/bench/data.json The data needs some pre-prosessing though. (See the chart.js bench at uPlot, that one is a good starting point) |
Closes #10348
Closes #10501
@thabarbados sorry for stepping on your pr, but as I already put some time to it, I figured its less time spend for everyone if I post this.
This performs consistently a little bit better than master on the default parsing case (uPlot dataset):
pr:
master: