Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable change of prefixes to existing options proxy #11105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable change of prefixes to existing options proxy #11105

wants to merge 2 commits into from
+34 −7

Conversation

stockiNail
Copy link
Contributor

Fix #11104

This PR is extending the prefixes to sub-nodes.

@stockiNail
Copy link
Contributor Author

@kurkle this PR should also enable the 'hover' options in subnodes (labels and captions), needed for chartjs-chart-treemap as well.

kurkle/chartjs-chart-treemap#175 (comment)

@stockiNail stockiNail mentioned this pull request Jan 31, 2023
Draft
5 tasks
@LeeLenaleee LeeLenaleee added this to the Version 4.3.0 milestone Feb 2, 2023
@etimberg etimberg requested a review from kurkle February 18, 2023 14:44
@stockiNail stockiNail mentioned this pull request Feb 18, 2023
Merged
@stockiNail stockiNail marked this pull request as draft March 2, 2023 16:45
@stockiNail
Copy link
Contributor Author

@etimberg @kurkle I set this PR in draft (to avoid any approval) because it must be changed, going to TS, after #11121 merged.

@stockiNail
Merge remote-tracking branch 'origin/master' into prefixes
8bad9b8 
Conflicts:
	src/helpers/helpers.config.js
@stockiNail stockiNail marked this pull request as ready for review March 22, 2023 09:08
@stockiNail
Copy link
Contributor Author

@dangreen @etimberg @kurkle I have changed going to TS (hopefully correctly). Available for your review.

@stockiNail
Copy link
Contributor Author

@etimberg etimberg modified the milestones: Version 4.3.0, Version 4.4.0 Apr 27, 2023
@etimberg etimberg removed this from the Version 4.4.2 milestone Feb 28, 2024
@kurkle
Copy link
Member

kurkle commented Nov 18, 2024

Looks like I dropped the ball with this 😞
I have no idea, why a sub resolver would not just inherit the prefixes in _resolveWithPrefixes.
But if it could be made there, nothing special would need to be done in plugins (it would be a breaking change though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle Awaiting requested review from kurkle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update prefixes to already existing proxy
4 participants
@stockiNail @kurkle @etimberg @LeeLenaleee