Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation about how to manage own custom plugin for types #11244

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

stockiNail
Copy link
Contributor

Fix types from plugins.

Error: node_modules/chartjs-plugin-annotation/types/index.d.ts:6:13 - error TS2428: All declarations of 'PluginOptionsByType' must have identical type parameters.6 interface PluginOptionsByType<TType extends ChartType> {

@etimberg etimberg added this to the Version 4.3.0 milestone Apr 20, 2023
@stockiNail
Copy link
Contributor Author

@etimberg I didn't add any test case for this "special" case. MAybe it could be acceptable to have it in the plugins project? What do you think?

@LeeLenaleee LeeLenaleee merged commit 69996ab into chartjs:master Apr 20, 2023
@stockiNail stockiNail deleted the fixPluginIntergation branch April 20, 2023 15:51
stockiNail added a commit to pepstock-org/Chart.js that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants