Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min js two renames #11470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix min js two renames #11470

wants to merge 1 commit into from
+25 −10

Conversation

fulldecent
Copy link
Contributor

This is alternative that incorporates #11457

@fulldecent fulldecent mentioned this pull request Aug 28, 2023
Open
@LeeLenaleee LeeLenaleee added this to the Version 4.5.0 milestone Aug 28, 2023
@etimberg
Copy link
Member

etimberg commented Sep 7, 2023

@fulldecent I think the test failures might be real. It looks like it fails to import https://github.com/chartjs/Chart.js/blob/master/test/BasicChartWebWorker.js#L9

@etimberg etimberg removed this from the Version 4.4.2 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulldecent @etimberg @LeeLenaleee