-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip fixes (getLabelAndValue on null controller, null getParsed) #11596
Conversation
I encountered chartjs#11315 under the following circumstances: 1. Position the cursor over the chart area, such that it causes a tooltip to be shown. 2. Move the cursor out of the chart area, such that the tooltip remains visible. 3. Cause the chart contents to be changed, such that the dataset referenced by the active tooltip element is no longer valid. 4. Move the mouse again. This triggers an `inChartArea = false` event, so it reuses the previous, now invalid, active elements. This fixes chartjs#11315 under the circumstances for which I've reproduced it, but there may be others.
This possibly fixes chartjs#11365.
@etimberg May need to increase the max build size of chartjs,
|
yeah, @kurkle @LeeLenaleee what do you think about just removing that compressed size step? It seems to fail more often than not and we just slowly increase the size |
Will merge and override the CI for now then we can remove the step in a separate PR |
Also opend an issue for this once, we already thought about removing it before 😅 |
Does the Release action need to be manually run? |
yeah, releases are manual. We'll need to bump the package.json version first and then run the release on github. |
Nice, I noticed the release-drafter was run. So next up is releasing a new patch version, then (cc @apertureless 🙏 ) |
@joshkel hi you!
So, I get error at line 1188.
Please check committed source again. |
I encountered #11315 under the following circumstances:
inChartArea = false
event, so it reuses the previous, now invalid, active elements.This fixes #11315 under the circumstances for which I've reproduced it, but there may be others.
#11365 appears to be caused by a similar issue (reused active elements that reference now-invalid datasetIndexes of valid datasets), so I've addressed that too.
These issues appear to be caused by #9970 - that added logic to leave active elements alone on chart update, to accommodate cases where the user was programmatically maintaining the active elements themselves.