Fix: applyStack() returned the sum of all values for hidden dataset indices, which causes incorrect animations when showing/hiding stacked datasets. #11938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndices, which resulted in wrong show animations
etimberg
approved these changes
Oct 24, 2024
kurkle
approved these changes
Oct 24, 2024
|
@etimberg I would really appreciate it, if you make a release with this change. Is it possible? |
|
@DeyLak sure, will do a release for this. |
LeeLenaleee
changed the title
|
This is now released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndices, which causes incorrect animations when showing/hiding stacked datasets. This fixes #11198.
This is a clone of this with added test, as I promised there.
I didn't find an easy way to test applyStack directly, so I decided that it would be better to test the behaviour and not the implementation and added a test for bar chart rendering.