Add package-lock.json #4486
Closed
Add package-lock.json #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
package-lock-2
branch
from
cc33d41 to
f150569
Compare
benmccann
force-pushed
the
package-lock-2
branch
from
f150569 to
3eb2f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommendation from npm team is that this file be checked in. I've updated Travis to use npm 5
I previously sent PR #4337 for this, but abandoned it because
gitbook-cliwas pulling in a malformed package. I've fixedgitbook-cliand a new release was cut, so this is no longer an issueThere was some concern that this file will be too noisy. However, I believe it will only update when package.json is updated and so it shouldn't be too noisy. If that turns out to be wrong then we can remove this file from the repo