-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run coveralls only on parent repo #4699
Conversation
I'm not sure if I would simply silent any error instead: - cat ./coverage/lcov.info | ./node_modules/.bin/coveralls 2>/dev/null Then it still working with forks integrating with their own coveralls accounts. |
Sorry, I had lost this PR from my radar. That would silence the error but would also do so for your regular build. If Might also do a
That should still print the error if there is one but not fail. |
@andig I like your version better (yes |
@andig were you going to update this PR to match your last comment? |
Sorry, I was somehow under the impression that it still needed discussion. Updated PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andig!
...otherwise each build in forks is broken which is highly confusing.