Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spanning data gaps for radar charts #5075

Closed
wants to merge 16 commits into from
Closed

Allow spanning data gaps for radar charts #5075

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
362470c
Allow spanning gaps for radar
flaurida Dec 22, 2017
90c2742
Fix options not being defined
flaurida Dec 22, 2017
85ac7e7
Support multiple point label font colors
flaurida Dec 22, 2017
9f769b4
Update documentation
flaurida Dec 22, 2017
5ad2ba9
Add test for spanGaps in radar chart
flaurida Dec 22, 2017
0f859e7
Remove type in linear docs
flaurida Dec 22, 2017
3084a9e
Fix typo in test
flaurida Dec 22, 2017
2df76e4
Fix another typo in test
flaurida Dec 22, 2017
4bea405
Try to address failing test
flaurida Dec 22, 2017
23468aa
Address review comment
flaurida Dec 23, 2017
2a6b81c
Remove unnecessary line
flaurida Dec 23, 2017
b28d11e
Fix wrong deleted line
flaurida Dec 23, 2017
936c822
Add JSON file and image tests
flaurida Dec 24, 2017
7b2a8d2
Update span gaps tests
flaurida Dec 26, 2017
374e220
Remove debug true from disable test
flaurida Dec 26, 2017
88ec1f2
Fix issue with span gaps option
flaurida Dec 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/axes/radial/linear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ The following options are used to configure the point labels that are shown on t
| Name | Type | Default | Description
| -----| ---- | --------| -----------
| `callback` | `Function` | | Callback function to transform data labels to point labels. The default implementation simply returns the current string.
| `fontColor` | `Color` | `'#666'` | Font color for point labels.
| `fontColor` | ``Color/Color[]`` | `'#666'` | Font color for point labels.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] looks like the backticks got duplicated on each side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, just pushed a fix up

| `fontFamily` | `String` | `"'Helvetica Neue', 'Helvetica', 'Arial', sans-serif"` | Font family to use when rendering labels.
| `fontSize` | `Number` | 10 | font size in pixels
| `fontStyle` | `String` | `'normal'` | Font style to use when rendering point labels.
1 change: 1 addition & 0 deletions docs/charts/radar.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ All point* properties can be specified as an array. If these are set to an array
| `pointHoverBorderColor` | `Color/Color[]` | Point border color when hovered.
| `pointHoverBorderWidth` | `Number/Number[]` | Border width of point when hovered.
| `pointHoverRadius` | `Number/Number[]` | The radius of the point when hovered.
| `spanGaps` | `Boolean` | If true, lines will be drawn between points with no or null data. If false, points with `NaN` data will create a break in the line

### pointStyle
The style of point. Options are:
Expand Down