Use the Chart.js shared ESLint config

[simonbrunel]

An ESLint shareable config has been created (from this repository) in the attempt to homogenize Chart.js hosted projects and plugins style. Rename .eslintrc files to .eslintrc.yml since the ([name has been deprecated(https://eslint.org/docs/user-guide/configuring#configuration-file-formats)) to .eslintrc.yml..

Fix the CC badge (maintainability) and disable CodeClimate ESLint plugin because it doesn't support custom shareable config but also because it already executes relevant checks as part of the regular process.

[simonbrunel]

Well, shareable config doesn't seem supported by CodeClimate (41 fixed issues)

[etimberg]

Looks like the 41 issues were all either statement count or the complexity. Is it OK to lose those?

[simonbrunel]

I think it actually lints nothing, as if the .eslintrc.yml was empty, so will not report real issues.

[etimberg]

Lots of discussion in codeclimate/codeclimate-eslint#86 that may be relevant

[etimberg]

Linting will still run for builds & PRs as its part of the CI as well. https://travis-ci.org/chartjs/Chart.js/builds/325810760#L2166

[simonbrunel]

I was reading it but no real solution. The closest is the fetch strategy, but it overrides the existing file which could have custom rules. I think it still great to have CodeClimate reporting complexity and statement count but if we disable ESLint, we will lose these stats.

[etimberg]

Maybe there's a codeclimate alternative we could consider? If the cost is low we could self host something, but I'd prefer not to do that if possible

[simonbrunel]

@etimberg I agree with you, we already run ESLint against our code during the build process on Travis and if there are errors, we don't really care about CC result. I think we still want complexity and statement count to be reported by CC because it highlights part of the code that need to be refactored. One solution would be to create a custom .eslintrc.cc.yml in the charts/eslint-config-chartjs repository and fetch it manually.

.eslintrc.cc.yml: enables only checks we want to be reported by CC

rules:
  complexity: [2, 10]
  max-statements: [2, 30]

.codeclimate.yml

prepare:
  fetch:
    - url: 'https://raw.githubusercontent.com/chartjs/eslint-config-chartjs/master/.eslintrc.cc.yml'
      path: '.eslintrc.yml'
engines:
  # ...

[simonbrunel]

It seems to work but actually, CC already have those checks enabled: https://docs.codeclimate.com/v1.0/docs/advanced-configuration#section-default-checks. So maybe the cleanest/simplest is to disable the ESLint CC plugin, what do you think?

[etimberg]

That works for me

[simonbrunel]

Commits squashed (CC ESLint disabled), I also fixed the CC badge

[etimberg]

Looks good to me. Can I merge?

[simonbrunel]

Yes, it needs at least one approval

[etimberg]

Will do tonight. Can’t on mobile