Update gulpfile.js to use in strict mode #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamknapik8
approved these changes
May 8, 2018
benmccann
reviewed
May 8, 2018
gulpfile.js
Outdated
| @@ -20,7 +20,7 @@ var yargs = require('yargs'); | |||
| var path = require('path'); | |||
| var fs = require('fs'); | |||
| var htmllint = require('gulp-htmllint'); | |||
| var package = require('./package.json'); | |||
| var _package = require('./package.json'); | |||
There was a problem hiding this comment.
it seems odd to me to have one variable with an underscore while none of the others have one. what do you think about calling it pkg instead of _package?
There was a problem hiding this comment.
Of course you right :) it's corrected now
etimberg
approved these changes
May 8, 2018
benmccann
approved these changes
May 9, 2018
|
@etimberg this seems like a pretty simple PR. Do you think we really need a second review from simonbrunel or could we just go ahead and merge it to help keep the queue clean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During build a project by gulp there is an error
"package" is a reserved word and cannot be used in strict mode
https://www.w3schools.com/js/js_reserved.asp