Is node shadow root check improved #5828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
reviewed
Nov 12, 2018
src/core/core.helpers.js
Outdated
| @@ -486,7 +486,7 @@ module.exports = function() { | |||
| */ | |||
| helpers._getParentNode = function(domNode) { | |||
| var parent = domNode.parentNode; | |||
| if (parent && parent.host) { | |||
| if (parent && Object.prototype.toString.call(parent) === '[object ShadowRoot]') { | |||
There was a problem hiding this comment.
I think I prefer if (parent && parent.toString() === '[object ShadowRoot]') { because it's better minified.
etimberg
approved these changes
Nov 17, 2018
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5826