Fix typos and minor doc issues #6020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
reviewed
Jan 28, 2019
|
Thanks @nagix for this cleanup work, I like when it's done in one go and consistently. |
|
Maybe it’s good time to convert all the primitive data types to lower case as suggested in #5925 (comment). |
|
I think I would try to follow the TypeScript Basic Types notations and Do's and Don'ts. If these conventions make sense for everyone, I agree it's the good time. |
etimberg
previously approved these changes
Jan 28, 2019
|
Added more fixes, coveted basic data types to lower case and introduced TypeScript's union type expression. |
simonbrunel
reviewed
Jan 28, 2019
benmccann
reviewed
Jan 28, 2019
benmccann
reviewed
Jan 28, 2019
benmccann
reviewed
Jan 28, 2019
benmccann
reviewed
Jan 28, 2019
benmccann
reviewed
Jan 28, 2019
benmccann
reviewed
Jan 28, 2019
benmccann
reviewed
Jan 28, 2019
|
Thanks for the comments. The suggested changes have been added. |
benmccann
approved these changes
Jan 29, 2019
simonbrunel
reviewed
Jan 29, 2019
simonbrunel
approved these changes
Jan 29, 2019
kurkle
approved these changes
Jan 29, 2019
etimberg
approved these changes
Jan 29, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos and minor issues making the doc more consistent.