Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle a frozen dataset.data array. #6060

Merged
merged 6 commits into from
Feb 11, 2019
Merged

Handle a frozen dataset.data array. #6060

merged 6 commits into from
Feb 11, 2019

Conversation

etimberg
Copy link
Member

Resolves #4157. I added a note to the documentation regarding the fact that frozen data will not support live updates.

Fiddle with v2.7.3
Fiddle with these changes

kurkle
kurkle requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @benmccann, the documentaton change is not needed.

kurkle
kurkle previously approved these changes Feb 10, 2019
View reviewed changes
benmccann
benmccann previously approved these changes Feb 10, 2019
View reviewed changes
@nagix
Copy link
Contributor

nagix commented Feb 10, 2019

I just wondered if we should use Object.isExtensible because Object.seal and Object.preventExtensions will cause the same issue.

@etimberg etimberg dismissed stale reviews from benmccann and kurkle via cadd326 February 10, 2019 20:42
@etimberg
Copy link
Member Author

@nagix I updated to use Object.isExtensible() and added tests for the Object.seal() and Object.preventExtensions() cases.

benmccann
benmccann previously approved these changes Feb 10, 2019
View reviewed changes
@simonbrunel simonbrunel added this to the Version 2.8 milestone Feb 10, 2019
nagix
nagix previously approved these changes Feb 11, 2019
View reviewed changes
kurkle
kurkle previously approved these changes Feb 11, 2019
View reviewed changes
@etimberg etimberg dismissed stale reviews from kurkle and nagix via dd980a8 February 11, 2019 12:10
simonbrunel
simonbrunel approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Evert!

@simonbrunel simonbrunel merged commit ef507e1 into chartjs:master Feb 11, 2019
jonrimmer pushed a commit to jonrimmer/Chart.js that referenced this pull request Feb 14, 2019
@etimberg @jonrimmer
Handle inextensible dataset.data array (chartjs#6060)
00c336e
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@etimberg @simonbrunel
Handle inextensible dataset.data array (chartjs#6060)
a6efc15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@simonbrunel simonbrunel simonbrunel approved these changes

@benmccann benmccann benmccann approved these changes

@nagix nagix nagix left review comments

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.8
Development

Successfully merging this pull request may close these issues.
5 participants
@etimberg @nagix @benmccann @simonbrunel @kurkle