Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize angle for index in radialLinear scale #6177

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Normalize angle for index in radialLinear scale #6177

merged 2 commits into from
Apr 2, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Apr 1, 2019

getIndexAngle returns a normalized angle value so that it stays between 0 and PI * 2. For the unit tests, support for textAlign property is added in the mock context.

Master: https://jsfiddle.net/nagix/gynkp7ec/
Screen Shot 2019-04-02 at 1 04 44 AM

This PR: https://jsfiddle.net/nagix/ef7r0w8h/
Screen Shot 2019-04-02 at 1 07 45 AM

Fixes #6160

@simonbrunel simonbrunel added this to the Version 2.9 milestone Apr 2, 2019
@simonbrunel simonbrunel merged commit c457b50 into chartjs:master Apr 2, 2019
@simonbrunel
Copy link
Member

Thanks @nagix

@nagix nagix deleted the issue-6177 branch April 2, 2019 09:27
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@nagix @simonbrunel
Normalize angle for index in radialLinear scale (chartjs#6177)
9059935
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
@renovate renovate bot mentioned this pull request Jul 31, 2021
Merged
1 task
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.
4 participants
@nagix @simonbrunel @benmccann @etimberg