-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply lineJoin style at the first point in radar charts #6269
Conversation
Just a random note: With |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO that mock canvas test should be removed.
@kurkle The radar chart create a gap with |
I agree to remove mock tests if we add image tests. |
@kurkle I may have misunderstood your comment - I think the cropped line border with On the other hand, |
|
@nagix not sure why the |
Removed loop line mock tests. |
#6282 was created to fix the |
lineJoin
style is not applied to the first point in radar charts. This PR fixes it by addingctx.closePath
if the line has a close path. If it is open, it shifts elements in the point array so that the line is correctly joined at the first point.I will add image tests in #6263 if this PR is merged first.
Master: https://jsfiddle.net/nagix/bf2geq3o/
This PR: https://jsfiddle.net/nagix/e36dp7k8/