Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getValueForPixel in time scale #6328

Merged
merged 2 commits into from
Jun 22, 2019
Merged

Fix getValueForPixel in time scale #6328

merged 2 commits into from
Jun 22, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Jun 10, 2019 •
edited
Loading

This PR fixes the following problems of getValueForPixel in time scale.

  • It doesn't support the ticks.reverse option
  • There is a bug in the offset calculation if offset is true

Master: https://jsfiddle.net/nagix/ot0npu3x/
Screen Shot 2019-06-10 at 8 30 13 AM

This PR: https://jsfiddle.net/nagix/gbd6sq92/
Screen Shot 2019-06-10 at 8 27 50 AM

kurkle
kurkle previously approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

etimberg
etimberg previously approved these changes Jun 10, 2019
View reviewed changes
benmccann
benmccann reviewed Jun 11, 2019
View reviewed changes
src/scales/scale.time.js Outdated Show resolved Hide resolved
src/scales/scale.time.js Outdated Show resolved Hide resolved
@nagix nagix dismissed stale reviews from etimberg and kurkle via 612f55e June 14, 2019 23:33
@etimberg etimberg merged commit 1c85700 into chartjs:master Jun 22, 2019
@nagix nagix added this to the Version 2.9 milestone Jun 24, 2019
@nagix nagix deleted the issue-6328 branch June 24, 2019 10:50
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@nagix @etimberg
Fix getValueForPixel in time scale (chartjs#6328)
ca698f8 
* Fix getValueForPixel in time scale

* Minor refactoring
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.
4 participants
@nagix @benmccann @etimberg @kurkle