Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Maximum call stack size exception in computeLabelSizes #7883

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Fix Maximum call stack size exception in computeLabelSizes #7883

merged 1 commit into from
Oct 17, 2020

Conversation

silentmatt
Copy link
Contributor

Calling Math.max with a large number of values was throwing an exception.
Tracking the current largest width and height as the widths and heights are
built up should be faster and avoids the exception.

@silentmatt
Fix Maximum call stack size exception in computeLabelSizes (chartjs#7881
4d4a395 
)

Calling Math.max with a large number of values was throwing an exception.
Tracking the current largest width and height as the widths and heights are
built up should be faster and avoids the exception.
@silentmatt
Copy link
Contributor Author

The same change could be made in the master branch, but I wasn't able to reproduce #7881. Something seems to have changed regarding the tickSize option, which might have been avoiding the issue.

@etimberg etimberg requested a review from kurkle October 15, 2020 11:15
kurkle
kurkle approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should do this for v3 too.

@etimberg
Copy link
Member

Would be a good idea to take this into v3 as well

@kurkle kurkle changed the title Fix Maximum call stack size exception in computeLabelSizes (#7881) Fix Maximum call stack size exception in computeLabelSizes Oct 17, 2020
@kurkle kurkle merged commit 42ed589 into chartjs:2.9 Oct 17, 2020
@silentmatt silentmatt deleted the 2.9 branch October 17, 2020 20:52
@silentmatt
Copy link
Contributor Author

I should be able to submit a PR for v3 soon. I figured I'd wait for this one to be approved first.

@etimberg
Copy link
Member

thanks @silentmatt

@silentmatt silentmatt mentioned this pull request Oct 17, 2020
Merged
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 12, 2021
Open
@martinakraus martinakraus mentioned this pull request Jun 5, 2024
Closed
@jaimeperez-vs jaimeperez-vs mentioned this pull request Jun 18, 2024
Open
This was referenced Aug 16, 2024
Open
Open
This was referenced Sep 8, 2024
Open
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
Open
@ryanmichaelfabayos ryanmichaelfabayos mentioned this pull request Sep 20, 2024
Open
@luisgarciaxygeni luisgarciaxygeni mentioned this pull request Sep 28, 2024
Open
@saadi1995 saadi1995 mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
version: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silentmatt @etimberg @kurkle