Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When objects are merged together, the target prototype can be polluted. #7918

Merged
merged 2 commits into from
Oct 18, 2020

Conversation

etimberg
Copy link
Member

No description provided.

This change blocks updates to the `__proto__` key during config merge
@simonbrunel
Copy link
Member

@etimberg @kurkle I think this PR introduced a breaking change when the passed config object is not a plain object (such as reactive data in Vue.js). For example, it breaks the "Events" samples of the datalabels plugin because the listeners options object is not iterable after the merge (example).

@kurkle
Copy link
Member

kurkle commented Mar 9, 2021

GramParallelo added a commit to GramParallelo/Chart.js that referenced this pull request Mar 23, 2022
dracos pushed a commit to mysociety/Chart.js that referenced this pull request Sep 25, 2023
…d. (chartjs#7918)

* When objects are merged together, the target prototype can be polluted.

This change blocks updates to the `__proto__` key during config merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants