Fix default when the plugin is defined in chart configuration #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeLenaleee
approved these changes
Jun 20, 2022
|
The suggested change is fine, though I would expect defaults to be applied even while using the plugin locally. |
simonbrunel
approved these changes
Jul 16, 2022
|
I was thinking the same. Maybe an issue should be submitted to chartjs project |
|
@simonbrunel I have seen that last merged PRs don't have the milestone. Will they be part of 2.1.0 or a bug fixing release 2.0.1? |
|
It will be 2.1.0 in which I would also like to include your other PR #271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #285
When the plugin is defined in chart configuration (and not globally registered) the offset and padding options were checked with a wrong default (0 instead of 4).