Use element width/height in fallback positioner #327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least couple of Chart.js extensions use x, y, width, height props in their elements, where x, y describe the top/left corner.
This change would utilize the width and height to determine the center point of the element.
This would be a breaking change if there is an extension that both has width/height on the elements and uses x/y for center point.
My initial thought was to move the positioners to defaults and use the element id to find from there, but its a bit larger change and would not work with derived element types (
instanceof PointElement
probably works for derived point elements).Also the defaults do not apply when the plugin is not registered globally.