Implement label events (enter, leave and click) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
force-pushed
the
feat/events
branch
from
1d41b83 to
ff1b687
Compare
Add a new `listeners` option (object), where the property is the type of the event to listen and the value a callback with a unique `context` argument containing the same information as for scriptable options. If a callback explicitly returns `true`, the label is updated with the modified context and the chart re-rendered. This allows to implement visual interactions with labels such as highlight, selection, etc. Note that there should be no performance penalty for configuration that don't use events since if there is no listener registered, we immediately ignore the incoming event and avoid useless extra computation.
simonbrunel
force-pushed
the
feat/events
branch
from
ff1b687 to
feedc25
Compare
|
@pingcheng @haimich will you guys be able to verify that PR? I would like to release 0.3.0 very soon and it would be great to have these changes tested before. You can grab built files directly from netlify (chartjs-plugin-datalabels.js and chartjs-plugin-datalabels.min.js) |
|
Hey @simonbrunel. Thanks for this! Do you happen to have a JSFiddle example with 0.3.0? UPDATE: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
listenersoption (object), where the property is the type of the event to listen and the value a callback with a uniquecontextargument containing the same information as for scriptable options. If a callback explicitly returnstrue, the label is updated with the modified context and the chart re-rendered. This allows to implement visual interactions with labels such as highlight, selection, etc.Note that there should be no performance penalty for configuration that don't use events since if there is no listener registered, we immediately ignore the incoming event and avoid useless extra computation.
Documentation & samples: listeners, highlight, selection
Fixes #17