Fixed: Cannot read property '$context' of null #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is a possibility to get `label` as `null` (https://github.com/chartjs/chartjs-plugin-datalabels/blob/master/src/plugin.js#L178) it should be also filtered out from updating.
simonbrunel
requested changes
Apr 27, 2018
src/plugin.js
Outdated
| @@ -232,8 +232,10 @@ Chart.plugins.register({ | |||
| update = updates[i]; | |||
| if (update[1]) { | |||
| label = update[0][EXPANDO_KEY]; | |||
| label.$context.active = (update[1] === 1); | |||
| label.update(label.$context); | |||
| if (label && label.$context) { | |||
There was a problem hiding this comment.
I would only test for label since label.$context should always be defined, else that's a bug and should not be silently ignored.
|
Reproduced in a complex chart but unfortunately can not isolate the issue :( |
|
Can you share your complex chart code? I'm curious why that happens because label could be null only if the element is hidden or skipped, in which case it should not be part of any interactions ( |
|
I'd share it already if I could. |
|
Thanks @pfrankov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is a possibility to get
labelasnull(https://github.com/chartjs/chartjs-plugin-datalabels/blob/master/src/plugin.js#L178) it should be also filtered out from updating.