Update helm module version to v3.2.1 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnake0
changed the title
|
Can we also update the Helm v2 version? There have been lot of bug fixes. Not sure if it will affect or not affect helm push, but it's best to keep things updated 😄 Latest 2.x.y version as of this writing is https://github.com/helm/helm/releases/tag/v2.16.9 |
This was referenced Sep 1, 2020
Closed
|
@karuppiah7890 I'd be happy to provide a PR, but I think it would make sense to update Helm 2.x in a separate PR. Also, supporting Helm 2 might not be possible, because client-go 1.18 introduced a massive breaking change with the addition of the context parameter. Can someone take a look at this PR? @jdolitsky ? |
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version of helm will format the yaml files whiling packaging, so for example the format and comments in
values.yamlwill be lost during the push, update the modules to newest version will solve this problemUpdate: the pull request #63 is a similar request, the conflict has been resolved