v4.0 review updates #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Local UDP API support! Now you can choose to listen to your Weather Stations observations directly over your local network. No Station ID or API Token needed. Observations are broadcasted every 60 seconds. This leverages the `obs_st` message. See [documentation](https://weatherflow.github.io/Tempest/api/udp/v171/) for more information.
- Fixed error in config.schema.json which was blocking display of occupancy sensor type. - Added note in README.md to indicate that `precip_accum_local_day` not available in local API.
Add description that states that `precip_accum_local_day` is not supported using Local API.
Disable `precip_accum_local_day` Occupancy Sensor if using Local API.
Merged
chasenicholl
merged commit 859a5f2
into
chasenicholl:local-websocket-support
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following files have been updated to incorporate my review comments:
I have tested code with Local API option as well as Cloud API.
precip_accum_local_dayis not supported in the Local API and has been blocked. It will be removed if you switch between Local and Cloud APIs if previously enabled.