-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConversationContent type inconsistency #76
Comments
supersnager
added a commit
that referenced
this issue
Nov 16, 2022
🎉 This issue has been resolved in version 1.9.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@victorchapado thanks for your vigilance! |
SlavaKatiukha
pushed a commit
to SlavaKatiukha/chat-ui-kit-react
that referenced
this issue
Oct 29, 2024
SlavaKatiukha
pushed a commit
to SlavaKatiukha/chat-ui-kit-react
that referenced
this issue
Oct 29, 2024
## [1.9.8](chatscope/chat-ui-kit-react@v1.9.7...v1.9.8) (2022-11-16) ### Bug Fixes * **chatscope#76:** rendering lastSenderName as a ReactNode ([20d09fd](chatscope@20d09fd)), closes [chatscope#76](chatscope#76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found an inconsistency between the definition of the
ConversationContent
type definition and the component implementation. The definition declares the property as a React.Node but the implementation only acceptsstring
:source
IMHO, I suggest continuing to accept a React node to be more flexible, something like this:
Thanks!
The text was updated successfully, but these errors were encountered: