Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConversationContent type inconsistency #76

Closed
victorchapado opened this issue Sep 25, 2022 · 2 comments
Closed

ConversationContent type inconsistency #76

victorchapado opened this issue Sep 25, 2022 · 2 comments
Assignees
Labels
bug Something isn't working released

Comments

@victorchapado
Copy link

I found an inconsistency between the definition of the ConversationContent type definition and the component implementation. The definition declares the property as a React.Node but the implementation only accepts string:

source

{typeof lastSenderName === "string" && (
  <LastSenderName name={lastSenderName} />
)}{" "}

IMHO, I suggest continuing to accept a React node to be more flexible, something like this:

{typeof lastSenderName === "string" ? (
  <LastSenderName name={lastSenderName} />
) : lastSenderName}{" "}

Thanks!

@supersnager supersnager self-assigned this Nov 16, 2022
@supersnager supersnager added the bug Something isn't working label Nov 16, 2022
github-actions bot pushed a commit that referenced this issue Nov 16, 2022
## [1.9.8](v1.9.7...v1.9.8) (2022-11-16)

### Bug Fixes

* **#76:** rendering lastSenderName as a ReactNode ([20d09fd](20d09fd)), closes [#76](#76)
@supersnager
Copy link
Contributor

🎉 This issue has been resolved in version 1.9.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@supersnager
Copy link
Contributor

@victorchapado thanks for your vigilance!

SlavaKatiukha pushed a commit to SlavaKatiukha/chat-ui-kit-react that referenced this issue Oct 29, 2024
SlavaKatiukha pushed a commit to SlavaKatiukha/chat-ui-kit-react that referenced this issue Oct 29, 2024
## [1.9.8](chatscope/chat-ui-kit-react@v1.9.7...v1.9.8) (2022-11-16)

### Bug Fixes

* **chatscope#76:** rendering lastSenderName as a ReactNode ([20d09fd](chatscope@20d09fd)), closes [chatscope#76](chatscope#76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants