courses page stuck on loading page when logged out #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Zahra-8d
commented
Aug 2, 2023
•
Zahra-8d
commented
- added documentation
- removed check for firebase update applied as its not necessary and when a user is not logged in and lands on an authed page, this will never be true
|
This fix isnt quite right. Needs rethinking |
|
@Zahra-8d - I'd like your thoughts on this PR (even though ive merged it). I think the user.loading flag in the _app.tsx page does all the work. I think we can delete the piece of state .firebaseUpdateApplied as the user.token seems to indicate the same thing anyways. So confusing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.