Add an ability to use custom Node.js for running VS Code #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
commented
Sep 27, 2022
azatsarynnyy
approved these changes
Oct 5, 2022
azatsarynnyy
pushed a commit
that referenced
this pull request
Oct 7, 2022
* Add an ability to use custom Node.js for running VS Code Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
azatsarynnyy
pushed a commit
that referenced
this pull request
Oct 9, 2022
* Add an ability to use custom Node.js for running VS Code Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: eclipse-che/che#21629, https://issues.redhat.com/browse/CRW-3261
At the moment for running VS Code
che-codeusesNode.js 16.14.0that requiresOpenSSL 1.1.1.There is no problem when
UBI 8based image is used in a devfile (UBI 8image uses 1.1.1 version ofopenssl). But it's impossible to start a workspace whenUBI 9based custom image is used (UBI 9image uses 3.0.1 version ofopenssl). Please see screenshots here.The changes allow a user to use an
UBI 9based custom image in a devfile. The requirements are:Node.js 16which statically links againstOpenSSL 3VSCODE_NODEJS_RUNTIME_DIRenvironment variable with path to the installed nodeAt the same time within a custom image a user can use any version of Node.js as default - I don't see here a problem.
Signed-off-by: Roman Nikitenko rnikiten@redhat.com