Define the 'dev' container as a target for merging a 'container contribution' #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
…ibution' Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
merge-contribution
branch
from
379d0eb
to
a868302
Compare
|
Pull Request images published ✨ |
|
@RomanNikitenko it's not required to specify the first container as the target for merging contributions anymore. See devfile/devworkspace-operator#993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Nikitenko rnikiten@redhat.com
What does this PR do?
Define the 'dev' container as a target for merging a 'container contribution'.
See description of the issue.
What issues does this PR fix?
eclipse-che/che#21738
How to test this PR?
After resolving eclipse-che/che#21738 we should check that a workspace starts successfully for the
che-coderepo.