Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Include the commands imported from a parent Devfile as to VS Code Tasks #197

Merged
merged 3 commits into from
Jul 19, 2023
Merged

fix: Include the commands imported from a parent Devfile as to VS Code Tasks #197

merged 3 commits into from
Jul 19, 2023

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Mar 29, 2023 •
edited
Loading

What does this PR do?

When Che-Code translates the Devfile Commands to VS Code Tasks, it ignored the commands defined in a parent Devfile. With this patch, parent Commands are imported now.

What issues does this PR fix?

addresses the #194 (comment)
fixes eclipse-che/che#22373

How to test this PR?

  1. Spin up a new workspace from the test project https://github.com/azatsarynnyy/inventory-quarkus/tree/with-parent which is configured to use the Che-Code image built from this PR.
  2. Open VS Code Tasks list and verify that the commands defined in the parent Devfile are listed as well as the commands defined in the project's Devfile:
    image

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions

This comment was marked as outdated.

Sign in to view
1 similar comment
@github-actions

This comment was marked as outdated.

Sign in to view
@azatsarynnyy
resolve merge conflicts
9512f78 
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@l0rd l0rd linked an issue Jul 18, 2023 that may be closed by this pull request
Parent commands are not available in VS Code tasks eclipse-che/che#22373
Closed
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@azatsarynnyy azatsarynnyy marked this pull request as ready for review July 19, 2023 07:22
@azatsarynnyy azatsarynnyy enabled auto-merge (squash) July 19, 2023 07:23
@azatsarynnyy azatsarynnyy mentioned this pull request Jul 19, 2023
Closed
RomanNikitenko
RomanNikitenko approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commands from the parent devfile are available for running:

image

@azatsarynnyy azatsarynnyy merged commit bce4ae6 into main Jul 19, 2023
1 of 2 checks passed
@azatsarynnyy azatsarynnyy deleted the parent-cmds branch July 19, 2023 07:44
@l0rd
Copy link
Contributor

l0rd commented Jul 19, 2023

I checked on dogfooding and the problem is fixed 🎉

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

9 similar comments
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

20 similar comments
@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@github-actions
Copy link

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-197-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-197-dev-amd64

@RomanNikitenko RomanNikitenko mentioned this pull request Aug 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0rd l0rd l0rd left review comments

@RomanNikitenko RomanNikitenko RomanNikitenko approved these changes

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy vitaliy-guliy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parent commands are not available in VS Code tasks
3 participants
@azatsarynnyy @l0rd @RomanNikitenko