-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support running VS Code in ubi9-based containers #317
Conversation
Pull Request Dev image published: |
4 similar comments
Pull Request Dev image published: |
Pull Request Dev image published: |
Pull Request Dev image published: |
Pull Request Dev image published: |
Pull Request Che-Code image published: |
When I try with this image (
Full entrypoint-logs.txt
Note that using this same image works with current checode. And that my expectation would be that it works on the UBI9 version of that too. |
@l0rd I'm not sure |
This is the default UBI8 image 🤷 , yes I guess you will have to find another check. |
@l0rd it worked well: also it worked for it's still draft PR, so, as I mentioned above - thanks for testing and reporting it! |
Pull Request Dev image published: |
Pull Request Che-Code image published: |
Pull Request Dev image published: |
1 similar comment
Pull Request Dev image published: |
Pull Request Che-Code image published: |
4b590c5
to
df5662d
Compare
@RomanNikitenko yes, we can update the repo settings - I have the required permissions. |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
…and is not available Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
db7c93e
to
30b4802
Compare
Pull Request Dev image published: |
Pull Request Che-Code image published: |
@ibuziuk |
@musienko-maxim could you please follow up with Roman on the verification? Basically, all the devfiles from https://registry.devfile.io/viewer / https://registry.devfile.io/index should work |
All devsamples have been tested on DogFooding instance. This was commented on here: https://issues.redhat.com/browse/CRW-5634. Short conclusion: |
I'm closing the current PR in favour of #324.
It was decided to use PR-324 approach, as it simplifies downstream project support |
Some adaptation is required for the downstream, so please do NOT merge the current PR - I'm going to provide the corresponding changes to the downstream while the current PR is under review.
What does this PR do?
The current solution works for
ubi8
andubi9
-based containers, seeHow to test this PR
section.What issues does this PR fix?
eclipse-che/che#21778
How to test this PR?
I tested it for the following images:
quay.io/devfile/universal-developer-image:ubi8-latest
registry.access.redhat.com/ubi8
registry.access.redhat.com/ubi8/ubi:8.8-1032.1692772289
registry.access.redhat.com/ubi8/openjdk-11:latest
registry.access.redhat.com/ubi8/nodejs-16:1-139
registry.access.redhat.com/ubi8/nodejs-18:1-32
registry.access.redhat.com/ubi9
registry.access.redhat.com/ubi9/ubi:9.3-1476
registry.access.redhat.com/ubi9/nodejs-18:1-84
registry.access.redhat.com/ubi9/python-39:1-161
registry.access.redhat.com/ubi9/go-toolset:1.19.13-4.1697647145
registry.access.redhat.com/ubi9/openjdk-17:1.17-1