feat: Add a setting that allows to control window header text separately from a window title #456

RomanNikitenko · 2024-11-20T13:40:52Z

What does this PR do?

Adds new setting window.header that allows to control window header text separately from a window title

What issues does this PR fix?

https://issues.redhat.com/browse/CRW-7258

How to test this PR?

I'm going to provide an ability to apply editor configurations from a configmap within another PR: #460.
So, you have to do some actions manually to test the current PR changes:

Start a workspace using editor image with the PR changes: quay.io/che-incubator-pull-requests/che-code:pr-456-amd64
File => Open File => /projects/.code-workspace
Add the following content:

"settings": {
      "window.header": "SOME TEST HEADER MESSAGE"
}

Refresh the page
Check header message

Does this PR contain changes that override default upstream Code-OSS behavior?

the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
the corresponding items were added to the CHANGELOG.md file
rules for automatic git rebase were added to the .rebase folder

github-actions · 2024-11-20T13:41:06Z

Click here to review and test in web IDE:

launcher/src/editor-configurations.ts

github-actions · 2024-12-02T10:39:35Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-456-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-456-dev-amd64

…ely from a window title Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

github-actions · 2024-12-02T11:28:34Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-456-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-456-dev-amd64

github-actions · 2024-12-02T11:38:25Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-456-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-456-dev-amd64

RomanNikitenko · 2024-12-02T12:15:18Z

I'm working on rules for automatic git rebase...

===
Update: it's done!

github-actions · 2024-12-02T12:56:33Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-456-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-456-dev-amd64

github-actions · 2024-12-03T08:45:57Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-456-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-456-dev-amd64

github-actions · 2024-12-03T08:46:04Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-456-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-456-dev-amd64

Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

github-actions · 2024-12-03T13:28:20Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-456-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-456-dev-amd64

vitaliy-guliy · 2024-12-06T12:31:00Z

code/src/vs/workbench/browser/parts/titlebar/windowTitle.ts

@@ -32,7 +32,8 @@ import { CodeWindow } from '../../../../base/browser/window.js';

 const enum WindowSettingNames {
 	titleSeparator = 'window.titleSeparator',
-	title = 'window.title'
+	title = 'window.title',
+	headerText = 'window.headerText'


Could we truncate property name to window.header ?

OK for me!
will provide the corresponding changes...

…r setting Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

github-actions · 2024-12-06T14:48:11Z

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-456-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-456-dev-amd64

devspacesbuild · 2024-12-06T15:38:36Z

Build 3.19 :: code_3.x/1511: Console, Changes, Git Data

RomanNikitenko changed the title ~~feat: Add a setting that allows to control window header test separately from a window title~~ feat: Add a setting that allows to control window header text separately from a window title Nov 20, 2024

This comment was marked as outdated.

Sign in to view

RomanNikitenko commented Nov 26, 2024

View reviewed changes

launcher/src/editor-configurations.ts Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

RomanNikitenko force-pushed the banner-message branch from a3d8e7a to dfcc024 Compare November 27, 2024 07:07

This comment was marked as outdated.

Sign in to view

RomanNikitenko changed the title ~~feat: Add a setting that allows to control window header text separately from a window title~~ feat: Ability ability to apply editor configurations from a configmap Nov 27, 2024

RomanNikitenko changed the title ~~feat: Ability ability to apply editor configurations from a configmap~~ feat: Ability to apply editor configurations from a configmap Nov 27, 2024

This comment was marked as outdated.

Sign in to view

RomanNikitenko changed the title ~~feat: Ability to apply editor configurations from a configmap~~ feat: Add a setting that allows to control window header text separately from a window title Dec 2, 2024

RomanNikitenko force-pushed the banner-message branch from 6256390 to dec1ba6 Compare December 2, 2024 10:36

RomanNikitenko added the made-with-che Changes made with Che-Code label Dec 2, 2024

RomanNikitenko added 2 commits December 2, 2024 11:23

feat: Add a setting that allows to control window header test separat…

336b845

…ely from a window title Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

chore: Update CHANGELOG file related to rebasing against upstream

0266ea0

Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

RomanNikitenko force-pushed the banner-message branch from dec1ba6 to 0266ea0 Compare December 2, 2024 11:53

RomanNikitenko marked this pull request as ready for review December 2, 2024 12:14

RomanNikitenko requested review from azatsarynnyy and vitaliy-guliy as code owners December 2, 2024 12:14

RomanNikitenko force-pushed the banner-message branch from 032dd10 to 6b1e15f Compare December 3, 2024 07:43

chore: Add rules for automatic rebasing

7d25bbf

Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

RomanNikitenko force-pushed the banner-message branch from 6b1e15f to 7d25bbf Compare December 3, 2024 12:26

vitaliy-guliy reviewed Dec 6, 2024

View reviewed changes

chore: Use just 'header' instead of 'headerText' for the window.heade…

7f6259f

…r setting Signed-off-by: RomanNikitenko <rnikiten@redhat.com>

vitaliy-guliy approved these changes Dec 6, 2024

View reviewed changes

RomanNikitenko merged commit 75377ec into main Dec 6, 2024
7 checks passed

RomanNikitenko deleted the banner-message branch December 6, 2024 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add a setting that allows to control window header text separately from a window title #456

feat: Add a setting that allows to control window header text separately from a window title #456

RomanNikitenko commented Nov 20, 2024 •

edited

Loading

github-actions bot commented Nov 20, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

RomanNikitenko commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

vitaliy-guliy Dec 6, 2024

RomanNikitenko Dec 6, 2024

github-actions bot commented Dec 6, 2024

devspacesbuild commented Dec 6, 2024

feat: Add a setting that allows to control window header text separately from a window title #456

feat: Add a setting that allows to control window header text separately from a window title #456

Conversation

RomanNikitenko commented Nov 20, 2024 • edited Loading

What does this PR do?

What issues does this PR fix?

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

github-actions bot commented Nov 20, 2024 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

RomanNikitenko commented Dec 2, 2024 • edited Loading

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

vitaliy-guliy Dec 6, 2024

Choose a reason for hiding this comment

RomanNikitenko Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 6, 2024

devspacesbuild commented Dec 6, 2024

RomanNikitenko commented Nov 20, 2024 •

edited

Loading

github-actions bot commented Nov 20, 2024 •

edited

Loading

RomanNikitenko commented Dec 2, 2024 •

edited

Loading