Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add peer dependency explicitly to the package.json #476

Merged
merged 3 commits into from
Dec 30, 2024
Merged

fix: Add peer dependency explicitly to the package.json #476

merged 3 commits into from
Dec 30, 2024

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Dec 25, 2024 •
edited
Loading

What does this PR do?

See #474

What issues does this PR fix?

https://issues.redhat.com/browse/CRW-7882

How to test this PR?

I tested adding the dependency to the downstream project - build passed successfully for the corresponding step.

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

@RomanNikitenko
fix: Add peer dependency explicitly to the package.json
212d8f9 
Signed-off-by: RomanNikitenko <rnikiten@redhat.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

Click here to review and test in web IDE: Contribute

@RomanNikitenko
chore: Add info related to rebasing against upstream
312cd2f 
Signed-off-by: RomanNikitenko <rnikiten@redhat.com>
@github-actions GitHub Actions
Copy link

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-476-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-476-dev-amd64

1 similar comment
@github-actions GitHub Actions
Copy link

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-476-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-476-dev-amd64

@RomanNikitenko RomanNikitenko added the made-with-che Changes made with Che-Code label Dec 25, 2024
@RomanNikitenko
chore: Add rules for automatic rebasing
428caea 
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@RomanNikitenko RomanNikitenko marked this pull request as ready for review December 25, 2024 14:56
@github-actions GitHub Actions
Copy link

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-476-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-476-dev-amd64

1 similar comment
@github-actions GitHub Actions
Copy link

Pull Request images published ✨

Editor: quay.io/che-incubator-pull-requests/che-code:pr-476-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-476-dev-amd64

@RomanNikitenko RomanNikitenko merged commit 306ae70 into main Dec 30, 2024
7 checks passed
@RomanNikitenko RomanNikitenko deleted the add-crypto branch December 30, 2024 08:59
@devspacesbuild
Copy link

Build 3.19 :: code_3.x/1527: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.19 :: sync-to-downstream_3.x/8420: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8523: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8523: FAILURE

code : 3.x :: Failed in 66293808 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliy-guliy vitaliy-guliy vitaliy-guliy approved these changes

@azatsarynnyy azatsarynnyy Awaiting requested review from azatsarynnyy azatsarynnyy is a code owner

Assignees
No one assigned
Labels
made-with-che Changes made with Che-Code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomanNikitenko @devspacesbuild @vitaliy-guliy