Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow to build che-code using cachito system #482

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Dec 30, 2024

What does this PR do?

Downstream project uses cachito system.
At the moment it's failing with the following error:

cachito - ERROR - Request is in "failed" state: keytar@file:node_modules/packageMocks/keytar is a 'file:' dependency. File dependencies are allowed if: a) the dependency is declared as a workspace in package.json or b) the dependency is present in the server-side allowlist.

Current changes should fix the problem.

What issues does this PR fix?

https://issues.redhat.com/browse/CRW-7882

How to test this PR?

  • build should pass successfully for the che-code
  • I'm going to test the changes in the downstream

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Signed-off-by: RomanNikitenko <rnikiten@redhat.com>
Copy link

github-actions bot commented Dec 30, 2024

Click here to review and test in web IDE: Contribute

Signed-off-by: RomanNikitenko <rnikiten@redhat.com>
Copy link

Copy link

Signed-off-by: RomanNikitenko <rnikiten@redhat.com>
Copy link

1 similar comment
Copy link

@RomanNikitenko RomanNikitenko merged commit f6b6fb0 into main Dec 30, 2024
7 checks passed
@RomanNikitenko RomanNikitenko deleted the keytar branch December 30, 2024 19:09
@devspacesbuild
Copy link

Build 3.19 :: code_3.x/1529: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: code_3.x/1529: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8425 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8530: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 66295034 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@RomanNikitenko RomanNikitenko added the made-with-che Changes made with Che-Code label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
made-with-che Changes made with Che-Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants