Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Adapt plugin to use new language test API #5

Merged
merged 50 commits into from
Sep 8, 2020

Conversation

svor
Copy link
Contributor

@svor svor commented Sep 2, 2020

This PR depends on eclipse-che/che-theia#802

Related issue: eclipse-che/che#14409

svor added 30 commits August 5, 2020 12:06
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
Signed-off-by: svor <vsvydenk@redhat.com>
@svor
Copy link
Contributor Author

svor commented Sep 2, 2020

@benoitf @ericwill @JPinkney FYI

Also I don't have write access to merge PRs in this repo.

@benoitf
Copy link

benoitf commented Sep 2, 2020

@svor now rights are ok ?

tests/helper.ts Outdated Show resolved Hide resolved
Signed-off-by: svor <vsvydenk@redhat.com>
@svor
Copy link
Contributor Author

svor commented Sep 2, 2020

@benoitf I still don't see Merge button =(

Signed-off-by: svor <vsvydenk@redhat.com>
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@benoitf
Copy link

benoitf commented Sep 2, 2020

@benoitf I still don't see Merge button =(

this project was only administered by Josh and I then applied it for all 'che team'
but you were not part of che-incubator ! I sent you an invitation. Should fix the issue

@svor
Copy link
Contributor Author

svor commented Sep 2, 2020

@benoitf I still don't see Merge button =(

this project was only administered by Josh and I then applied it for all 'che team'
but you were not part of che-incubator ! I sent you an invitation. Should fix the issue

it's OK now, thank you

Signed-off-by: svor <vsvydenk@redhat.com>
src/extension.ts Outdated Show resolved Hide resolved
Signed-off-by: svor <vsvydenk@redhat.com>
src/extension.ts Outdated Show resolved Hide resolved
Signed-off-by: svor <vsvydenk@redhat.com>
@benoitf
Copy link

benoitf commented Sep 3, 2020

Hello, is it planned in a "next step" to split/move what is pure "test of the java LS stuff" from the "running tests, write into a log file the results" and check if there are failures, etc ?

Let say tomorrow you add a test extension for Python or TypeScript, maybe lot of stuff could be shared.

@svor
Copy link
Contributor Author

svor commented Sep 3, 2020

Hello, is it planned in a "next step" to split/move what is pure "test of the java LS stuff" from the "running tests, write into a log file the results" and check if there are failures, etc ?

Let say tomorrow you add a test extension for Python or TypeScript, maybe lot of stuff could be shared.

We haven't discussed it yet, but it is a good idea
@ericwill FYI

src/test-reporter.ts Outdated Show resolved Hide resolved
src/test-reporter.ts Outdated Show resolved Hide resolved
svor and others added 2 commits September 3, 2020 15:31
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
@svor svor merged commit ec40ea6 into che-incubator:master Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants