-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use crd v1beta1 if kubernetes doesn't support v1 #1193
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 10.26% 10.28% +0.02%
==========================================
Files 60 60
Lines 6032 6035 +3
Branches 1016 1016
==========================================
+ Hits 619 621 +2
- Misses 5413 5414 +1
Continue to review full report at Codecov.
|
--force-crd-v1beta1
flag--force-crd-v1beta1
flag
@tolusha it would be nice to have in the description why do we need to force CRD version. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
c0e99ec
to
156013c
Compare
--force-crd-v1beta1
flagThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, this way is better than your previous and suggested by me.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tolusha: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Use crd v1beta1 if kubernetes doesn't support v1
What issues does this PR fix or reference?
eclipse-che/che#19648
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.