Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use crd v1beta1 if kubernetes doesn't support v1 #1193

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

tolusha
Copy link
Collaborator

@tolusha tolusha commented Apr 23, 2021

@codecov-commenter
Copy link

Codecov Report

Merging #1193 (c0e99ec) into main (c3b5a87) will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
+ Coverage   10.26%   10.28%   +0.02%     
==========================================
  Files          60       60              
  Lines        6032     6035       +3     
  Branches     1016     1016              
==========================================
+ Hits          619      621       +2     
- Misses       5413     5414       +1     
Impacted Files Coverage Δ
src/commands/server/deploy.ts 0.00% <0.00%> (ø)
src/commands/server/update.ts 0.00% <0.00%> (ø)
src/tasks/installers/operator.ts 0.00% <0.00%> (ø)
src/common-flags.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b5a87...c0e99ec. Read the comment docs.

@tolusha tolusha changed the title Introduce --force-crd-v1beta1 flag feat: Introduce --force-crd-v1beta1 flag Apr 23, 2021
@mmorhun
Copy link
Contributor

mmorhun commented Apr 23, 2021

@tolusha it would be nice to have in the description why do we need to force CRD version.
As about flag name, does it make sense to have: --force-crd-version v1beta1? This way we will not need another flag if a new CRD version needs to be applied during the deploy process.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha changed the title feat: Introduce --force-crd-v1beta1 flag Use crd v1beta1 if kubernetes doesn't support v1 Apr 23, 2021
@tolusha tolusha changed the title Use crd v1beta1 if kubernetes doesn't support v1 fix: Use crd v1beta1 if kubernetes doesn't support v1 Apr 23, 2021
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this way is better than your previous and suggested by me.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun removed their assignment Apr 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Apr 23, 2021

@tolusha: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v8-chectl-e2e-operator-installer 156013c link /test v8-chectl-e2e-operator-installer
ci/prow/v7-chectl-e2e-olm-installer 156013c link /test v7-chectl-e2e-olm-installer

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants