feat(inject): Allow to inject a kubeconfig with the specified context #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
azatsarynnyy
changed the title
azatsarynnyy
requested review from
benoitf,
l0rd,
rhopp and
vparfonov
as code owners
|
Could someone take a look at the PR? @benoitf |
This was referenced Dec 12, 2019
| @@ -92,10 +98,23 @@ export default class Inject extends Command { | |||
| }) | |||
| } | |||
|
|
|||
| async injectKubeconfigTasks(flags: any, chenamespace: string, workspace: string, container?: string): Promise<Listr> { | |||
| async injectKubeconfigTasks(flags: any): Promise<Listr> { | |||
There was a problem hiding this comment.
Do we really need to use any?
There was a problem hiding this comment.
Yes, I think. And what's your opinion @AndrienkoAleksandr?
AndrienkoAleksandr
approved these changes
Dec 20, 2019
tolusha
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com
What does this PR do?
Adds the parameter
--contextto theworkspace:injectcommand. It's used to specify the context to be injected. If no--contextparameter is provided, the current context will be injected.What issues does this PR fix or reference?
eclipse-che/che#14877 (1'st sub-task)