Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional debug output to the prepare assembly step #48

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

vzhukovs
Copy link
Collaborator

Print java configuration to the log output on prepare assembly step

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

@vzhukovs vzhukovs requested a review from benoitf July 29, 2021 12:14
@vzhukovs vzhukovs self-assigned this Jul 29, 2021
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only FYI: just thinking it could be helpful to have constants or aliases for your log levels so it's easier to know what is verbose or error etc very quickly when looking at the code

like .log ${TRACE} .log ${INFO}
or aliases
.log:trace "Read PATH env: $PATH"`` trace "Read PATH env: $PATH"``

@vzhukovs
Copy link
Collaborator Author

only FYI: just thinking it could be helpful to have constants or aliases for your log levels so it's easier to know what is verbose or error etc very quickly when looking at the code

like .log ${TRACE} .log ${INFO}
or aliases
.log:trace "Read PATH env: $PATH" trace "Read PATH env: $PATH"

Yep, also thought about it. Because there are a lot of log messages and they needs to be organized for readability. Will provide such improvements in next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants