ci: add per-arch support for installation of libsecret and libsecret-devel #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickboldt
commented
Aug 4, 2021
benoitf
reviewed
Aug 4, 2021
nickboldt
commented
Aug 4, 2021
| # Java 11 support | ||
| java-11-openjdk-devel \ | ||
| # Python support | ||
| python2 python39 \ | ||
| # Packages needed for AWT. | ||
| libXext libXrender libXtst libXi libX11-xcb mesa-libgbm libdrm freetype \ | ||
| # Arch specific installs of libsecret and libsecret-devel (required by JetBrains products) | ||
| && chmod +x /tmp/install-platform-dependencies.sh && /tmp/install-platform-dependencies.sh && rm -f /tmp/install-platform-dependencies.sh \ |
There was a problem hiding this comment.
to transform to downstream:
sed Dockerfile -r -e "s#.+install-platform-dependencies.sh.+# libsecret libsecret-devel \\\\ #" > Dockerfile.2
mv Dockerfile.2 Dockerfile
nickboldt
changed the title
nickboldt
force-pushed
the
s390x-ppc64le-
branch
from
ef86d0f to
5c54d79
Compare
vzhukovs
approved these changes
Aug 4, 2021
benoitf
reviewed
Aug 4, 2021
nickboldt
force-pushed
the
s390x-ppc64le-
branch
from
5c54d79 to
b0fe4af
Compare
benoitf
reviewed
Aug 5, 2021
| cd /tmp | ||
| curl -sSLO https://rpmfind.net/linux/fedora-secondary/releases/34/Everything/s390x/os/Packages/l/libsecret-0.20.4-2.fc34.s390x.rpm | ||
| curl -sSLO https://rpmfind.net/linux/fedora-secondary/releases/34/Everything/s390x/os/Packages/l/libsecret-devel-0.20.4-2.fc34.s390x.rpm | ||
| rpm --excludedocs -i /tmp/libsecret-*.rpm |
There was a problem hiding this comment.
FYI glib2-devel pcre-cpp pcre-devel pcre-utf16 pcre-utf32 are packages to install on s390x before installing libsecret*
…devel Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
force-pushed
the
s390x-ppc64le-
branch
from
67b19ab to
951db7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add per-arch support for installation of libsecret and libsecret-devel; also update to latest ubi8-minimal base images, and include URL from which they're kept up to date so we can use updateBaseImages.sh script at intervals to stay current
Change-Id: I9cb90974484472826deaff3658daec9b47d23ffb
Signed-off-by: nickboldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.