Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide sidecar-less model #70

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Provide sidecar-less model #70

merged 1 commit into from
Jan 11, 2022

Conversation

vzhukovs
Copy link
Collaborator

Current changes proposal provides sidecar-less mode according to eclipse-che/che#20863

Main highlights from the current proposed changes:

  • refactored Dockerfile by moving environment configuration from runtime image to builder image
  • builder image is based on the ubi8 instead of ubi8-minimal
  • removed install-platform-dependencies.sh and moved the code to the builder image
  • added runtime argument nosplash
  • added sh script which copies the configured editor to another runtime image by mounting a shared volume
  • added sh script which runs the configured editor in another runtime image
  • reworked runtime user configuration

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs requested review from benoitf and removed request for benoitf January 11, 2022 09:12
# SPDX-License-Identifier: EPL-2.0
#

# necessary environment variables: PROJECTOR_VOLUME_MOUNT and PROJECTOR_ASSEMBLY_DIR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, from where come these environment variables ?

Copy link
Collaborator Author

@vzhukovs vzhukovs Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants